Date: Mon, 31 Jan 2005 23:27:54 +0100
From: Stelian Pop <stelian@popies.net>
To: dtor_core@ameritech.net
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static
Message-ID: <20050131222753.GG28886@deep-space-9.dsnet>
Reply-To: Stelian Pop <stelian@popies.net>
Mail-Followup-To: Stelian Pop <stelian@popies.net>,
	dtor_core@ameritech.net, Adrian Bunk <bunk@stusta.de>,
	linux-kernel@vger.kernel.org
References: <20050131173508.GS18316@stusta.de> <20050131214905.GF28886@deep-space-9.dsnet> <d120d500050131141358ff63c9@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d120d500050131141358ff63c9@mail.gmail.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1142
Lines: 31

On Mon, Jan 31, 2005 at 05:13:22PM -0500, Dmitry Torokhov wrote:

> On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <stelian@popies.net> wrote:
> > 
> > sonypi.h is a "local" header file used only by sonypi.c.
> > 
> > I would like to keep those tables in sonypi.h rather than putting
> > all into sonypi.c (or we could as well remove sonypi.h and put all the
> > contents into the .c).
> > 
> 
> Hi,
> 
> What is the point of having an .h file if it is not used by anyone?
> Judging by the fact that it completely protected by #ifdef __KERNEL__
> there should be no userspace clients either.
> 
> I always thought that the only time .h is needed is when you define
> interface to your code. I'd fold it to sonpypi.c.

It isn't strictly *needed*, but it does separate a bit the data
structures and the constants (in the .h) from the code (in the .c).

Stelian.
-- 
Stelian Pop <stelian@popies.net>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/