Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262234AbVBBEAd (ORCPT ); Tue, 1 Feb 2005 23:00:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262228AbVBBDDe (ORCPT ); Tue, 1 Feb 2005 22:03:34 -0500 Received: from [211.58.254.17] ([211.58.254.17]:10890 "EHLO hemosu.com") by vger.kernel.org with ESMTP id S262234AbVBBCwu (ORCPT ); Tue, 1 Feb 2005 21:52:50 -0500 Date: Wed, 2 Feb 2005 11:52:48 +0900 From: Tejun Heo To: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 2.6.11-rc2 10/29] ide: __ide_do_rw_disk() return value fix Message-ID: <20050202025248.GK621@htj.dyndns.org> References: <20050202024017.GA621@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050202024017.GA621@htj.dyndns.org> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 31 > 10_ide_do_rw_disk_pre_task_out_intr_return_fix.patch > > In __ide_do_rw_disk(), ide_started used to be returned blindly > after issusing PIO write. This can cause hang if > pre_task_out_intr() returns ide_stopped due to failed > ide_wait_stat() test. Fixed to pass the return value of > pre_task_out_intr(). Signed-off-by: Tejun Heo Index: linux-ide-export/drivers/ide/ide-disk.c =================================================================== --- linux-ide-export.orig/drivers/ide/ide-disk.c 2005-02-02 10:28:03.898413061 +0900 +++ linux-ide-export/drivers/ide/ide-disk.c 2005-02-02 10:28:04.080383536 +0900 @@ -253,8 +253,7 @@ ide_startstop_t __ide_do_rw_disk (ide_dr /* FIXME: ->OUTBSYNC ? */ hwif->OUTB(command, IDE_COMMAND_REG); - pre_task_out_intr(drive, rq); - return ide_started; + return pre_task_out_intr(drive, rq); } } EXPORT_SYMBOL_GPL(__ide_do_rw_disk); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/