Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262748AbVBBS6O (ORCPT ); Wed, 2 Feb 2005 13:58:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262568AbVBBS4q (ORCPT ); Wed, 2 Feb 2005 13:56:46 -0500 Received: from kenga.kmv.ru ([217.13.212.5]:19901 "EHLO kenga.kmv.ru") by vger.kernel.org with ESMTP id S262348AbVBBSy6 (ORCPT ); Wed, 2 Feb 2005 13:54:58 -0500 Date: Wed, 2 Feb 2005 21:53:39 +0300 From: "Andrey J. Melnikoff (TEMHOTA)" To: Vasily Averin Cc: Marcelo Tosatti , linux-kernel@vger.kernel.org, Atul Mukker , Sreenivas Bagalkote Subject: Re: [PATCH] Prevent NMI oopser Message-ID: <20050202185338.GG19453@kmv.ru> References: <41F5FC96.2010103@sw.ru> <20050131231752.GA17126@logos.cnet> <42011EFA.10109@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42011EFA.10109@sw.ru> User-Agent: Mutt/1.5.6+20040907i X-Data-Status: msg.XXeUZUDa:28661@kenga.kmv.ru Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 35 Hi Vasily Averin! On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote next: > Marcelo Tosatti wrote: > >On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: > >>You should unlock io_request_lock before msleep, like in latest versions > >>of megaraid2 drivers. > > > >Andrey, > > > >Can you please update your patch to unlock io_request_lock before sleeping > >and locking after coming back? > > > >What the driver is doing is indeed wrong. > > Marcelo, > > This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible > version that I've seen), Where ? Last version (i see announce + patch from 2.10.3) is 2.10.6. > taken from latest RHEL3 kernel update. I believe it should prevent NMI > in abort/reset handler. Thnx for patch, I try it on my server at next week. -- Best regards, TEMHOTA-RIPN aka MJA13-RIPE System Administrator. mailto:temnota@kmv.ru - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/