Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262406AbVBBWwP (ORCPT ); Wed, 2 Feb 2005 17:52:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262695AbVBBWuI (ORCPT ); Wed, 2 Feb 2005 17:50:08 -0500 Received: from stat16.steeleye.com ([209.192.50.48]:24989 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S262913AbVBBWnf (ORCPT ); Wed, 2 Feb 2005 17:43:35 -0500 Subject: RE: [Announce] megaraid_mbox 2.20.4.4 patch From: James Bottomley To: "Ju, Seokmann" Cc: Matt Domsch , Linux Kernel , SCSI Mailing List , "Bagalkote, Sreenivas" , "Mukker, Atul" In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570366265E@exa-atlanta> References: <0E3FA95632D6D047BA649F95DAB60E570366265E@exa-atlanta> Content-Type: text/plain Date: Wed, 02 Feb 2005 16:43:21 -0600 Message-Id: <1107384201.4541.30.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 684 Lines: 19 On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote: > + .sdev_attrs = megaraid_device_attrs, > + .shost_attrs = megaraid_class_device_attrs, These are, perhaps, slightly confusing names. The terms device and class_device have well defined meanings in the generic device model, neither of which is what you mean here. Why not simply megaraid_sdev_attrs and megaraid_shost_attrs? Other than this, it looks fine to me too. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/