Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262247AbVBCAE5 (ORCPT ); Wed, 2 Feb 2005 19:04:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262651AbVBBXw2 (ORCPT ); Wed, 2 Feb 2005 18:52:28 -0500 Received: from mx1.redhat.com ([66.187.233.31]:65459 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262450AbVBBXqJ (ORCPT ); Wed, 2 Feb 2005 18:46:09 -0500 Date: Wed, 2 Feb 2005 18:46:00 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Fruhwirth Clemens cc: Andrew Morton , , , "David S. Miller" Subject: Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm In-Reply-To: <1107386909.19339.9.camel@ghanima> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 35 On Thu, 3 Feb 2005, Fruhwirth Clemens wrote: > > > +static int ecb_process_gw(void *_priv, int nsg, void **buf) > > > What does _gw mean? > > generic walker.. can be removed, if you like. That's fine, was just wondering. > > > + r = pf(priv, nsl, dispatch_list); > > > + if(unlikely(r < 0)) > > > + goto out; > > > > Not sure if the unlikely() is justified here, given that this is not a > > fast path. I guess it doesn't do any harm. > > I suspected unlikely to be a hint for the compiler to do better jump > prediction and speculations. Remove? Correct, although I think this will get lost in the noise given that it's sitting in the middle of crypto processing. I'd remove it. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/