Message-ID: <42020C29.99CF1D87@tv-sign.ru>
Date: Thu, 03 Feb 2005 14:34:01 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
MIME-Version: 1.0
To: Ram <linuxram@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Steven Pratt <slpratt@austin.ibm.com>,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/4] readahead: factor out duplicated code
References: <41FB6F45.848CEFF6@tv-sign.ru>  <41FB7517.418D556A@tv-sign.ru> <1107398594.5992.134.camel@localhost>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1086
Lines: 31

Ram wrote:
> > unsigned long page_cache_readahead(mapping, ra, filp, offset, req_size)
> > {
> > 	unsigned long max, newsize = req_size;
> > 	int sequential = (offset == ra->prev_page + 1);
> >
> > 	if (offset == ra->prev_page && req_size == 1 && ra->size != 0)
> > 		goto out;
> > 	ra->prev_page = offset;		<============== PLEASE LOOK HERE :)
> > 	max = get_max_readahead(ra);
> > 	newsize = min(req_size, max);
> >
> > 	if (newsize == 0 || (ra->flags & RA_FLAG_INCACHE)) {
> > 		newsize = 1;
>
> At this point prev_page has to be updated:
>               ra->prev_page = offset;

Yes, it is already updated, before "max = get_max_readahead(ra);"

> Otherwise this code looks much cleaner and correct. Can you send me a
> updated patch. I will run it through my test harness.

Well, currently I do not know, what should be changed :)

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/