Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262843AbVBCLGV (ORCPT ); Thu, 3 Feb 2005 06:06:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262687AbVBCLCh (ORCPT ); Thu, 3 Feb 2005 06:02:37 -0500 Received: from isilmar.linta.de ([213.239.214.66]:60297 "EHLO linta.de") by vger.kernel.org with ESMTP id S262896AbVBCLCB (ORCPT ); Thu, 3 Feb 2005 06:02:01 -0500 Date: Thu, 3 Feb 2005 12:01:55 +0100 From: Dominik Brodowski To: Pavel Machek Cc: "Rafael J. Wysocki" , LKML , Dave Jones Subject: Re: cpufreq problem wrt suspend/resume on Athlon64 Message-ID: <20050203110155.GA17576@isilmar.linta.de> Mail-Followup-To: Dominik Brodowski , Pavel Machek , "Rafael J. Wysocki" , LKML , Dave Jones References: <200502021428.12134.rjw@sisk.pl> <20050202133153.GD29579@elf.ucw.cz> <200502030108.09508.rjw@sisk.pl> <20050203104126.GC1389@elf.ucw.cz> <20050203105647.GA17526@isilmar.linta.de> <20050203105846.GA1360@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050203105846.GA1360@elf.ucw.cz> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 26 On Thu, Feb 03, 2005 at 11:58:46AM +0100, Pavel Machek wrote: > Hi! > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > Okay, you are right, restoring it unconditionaly would be bad > > > idea. Still it would be nice to tell cpufreq governor "please change > > > the frequency ASAP" so it does not run at 800MHz for half an hour > > > compiling kernels on AC power. > > > > It already does that... or at least it should. in cpufreq_resume() there is > > a call to schedule_work(&cpu_policy->update); which will cause a call > > cpufreq_update_policy() in due course. And cpufreq_update_policy() calls the > > governor, and it is supposed to adjust the frequency to the user's wish > > then. > > Ok, so Rafael's suspend() routine seems like good fix... No. I don't see a reason why my desktop P4 should drop to 12.5 frequency (p4-clockmod) if I ask it to suspend to mem. Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/