Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263138AbVBCNdG (ORCPT ); Thu, 3 Feb 2005 08:33:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263106AbVBCNc7 (ORCPT ); Thu, 3 Feb 2005 08:32:59 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:20937 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S262840AbVBCNcd (ORCPT ); Thu, 3 Feb 2005 08:32:33 -0500 Date: Thu, 3 Feb 2005 14:32:29 +0100 From: Jens Axboe To: Bartlomiej Zolnierkiewicz Cc: Tejun Heo , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 2.6.11-rc2 11/29] ide: add ide_drive_t.sleeping Message-ID: <20050203133228.GA2816@suse.de> References: <20050202024017.GA621@htj.dyndns.org> <20050202025448.GL621@htj.dyndns.org> <58cb370e05020216476a8f403c@mail.gmail.com> <20050203113710.GV5710@suse.de> <58cb370e05020305304e5d504@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58cb370e05020305304e5d504@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 31 On Thu, Feb 03 2005, Bartlomiej Zolnierkiewicz wrote: > On Thu, 3 Feb 2005 12:37:10 +0100, Jens Axboe wrote: > > On Thu, Feb 03 2005, Bartlomiej Zolnierkiewicz wrote: > > > On Wed, 2 Feb 2005 11:54:48 +0900, Tejun Heo wrote: > > > > > 11_ide_drive_sleeping_fix.patch > > > > > > > > > > ide_drive_t.sleeping field added. 0 in sleep field used to > > > > > indicate inactive sleeping but because 0 is a valid jiffy > > > > > value, though slim, there's a chance that something can go > > > > > weird. And while at it, explicit jiffy comparisons are > > > > > converted to use time_{after|before} macros. > > > > > > Same question as for "add ide_hwgroup_t.polling" patch. > > > AFAICS drive->sleep is either '0' or 'timeout + jiffies' (always > 0) > > > > Hmm, what if jiffies + timeout == 0? > > Hm, jiffies is unsigned and timeout is always > 0 > but this is still possible if jiffies + timeout wraps, right? Precisely, if jiffies is exactly 'timeout' away from wrapping to 0 it could happen. So I think the fix looks sane. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/