Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263791AbVBCTbS (ORCPT ); Thu, 3 Feb 2005 14:31:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263735AbVBCTU7 (ORCPT ); Thu, 3 Feb 2005 14:20:59 -0500 Received: from wproxy.gmail.com ([64.233.184.207]:45434 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S263248AbVBCRqg (ORCPT ); Thu, 3 Feb 2005 12:46:36 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=ZOde/KZKGKXdvnQQ0wzuCirUiBjX0md5hU/SM4IQ4MQhndpwa1WWXg+eqL99ddtKSQANMpGHrq/6kuS7suOPVBKV4oveluuuhTExEzoAPXI28+KS9a+jLUUyAeKdOkAAMUxviKfXeb3goGhywLNA8xwqqc8RXdYa72eB36cwplk= Message-ID: <58cb370e05020309464a106816@mail.gmail.com> Date: Thu, 3 Feb 2005 18:46:00 +0100 From: Bartlomiej Zolnierkiewicz Reply-To: Bartlomiej Zolnierkiewicz To: Tejun Heo Subject: Re: [PATCH 2.6.11-rc2 25/29] ide: convert REQ_DRIVE_CMD to REQ_DRIVE_TASKFILE Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org In-Reply-To: <20050202031559.GP1187@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <20050202024017.GA621@htj.dyndns.org> <20050202031559.GP1187@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1952 Lines: 42 On Wed, 2 Feb 2005 12:15:59 +0900, Tejun Heo wrote: > > 25_ide_taskfile_cmd.patch > > > > All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl() > > converted to use REQ_DRIVE_TASKFILE. > > Signed-off-by: Tejun Heo > > Index: linux-ide-export/drivers/ide/ide-disk.c > =================================================================== > --- linux-ide-export.orig/drivers/ide/ide-disk.c 2005-02-02 10:28:06.527986413 +0900 > +++ linux-ide-export/drivers/ide/ide-disk.c 2005-02-02 10:28:07.204876587 +0900 > @@ -750,7 +750,7 @@ static int set_multcount(ide_drive_t *dr > if (drive->special.b.set_multmode) > return -EBUSY; > ide_init_drive_cmd (&rq); > - rq.flags = REQ_DRIVE_CMD; > + rq.flags = REQ_DRIVE_TASKFILE; Please instead fix ide_init_drive_cmd() to set REQ_DRIVE_TASKFILE and add set REQ_DRIVE_CMD only in ide_cmd_ioctl(). > drive->mult_req = arg; > drive->special.b.set_multmode = 1; > (void) ide_do_drive_cmd (drive, &rq, ide_wait); > Index: linux-ide-export/drivers/ide/ide.c > =================================================================== > --- linux-ide-export.orig/drivers/ide/ide.c 2005-02-02 10:27:14.652402828 +0900 > +++ linux-ide-export/drivers/ide/ide.c 2005-02-02 10:28:07.205876425 +0900 > @@ -1255,6 +1255,7 @@ static int set_pio_mode (ide_drive_t *dr > if (drive->special.b.set_tune) > return -EBUSY; > ide_init_drive_cmd(&rq); > + rq.flags = REQ_DRIVE_TASKFILE; > drive->tune_req = (u8) arg; > drive->special.b.set_tune = 1; > (void) ide_do_drive_cmd(drive, &rq, ide_wait); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/