Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261246AbVBDAXw (ORCPT ); Thu, 3 Feb 2005 19:23:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263227AbVBDAXv (ORCPT ); Thu, 3 Feb 2005 19:23:51 -0500 Received: from sv1.valinux.co.jp ([210.128.90.2]:51860 "EHLO sv1.valinux.co.jp") by vger.kernel.org with ESMTP id S261778AbVBDAXn (ORCPT ); Thu, 3 Feb 2005 19:23:43 -0500 Date: Fri, 04 Feb 2005 09:23:47 +0900 From: Itsuro Oda To: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [Fastboot] [PATCH] Reserving backup region for kexec based crashdumps. Cc: Koichi Suzuki , Vivek Goyal , Andrew Morton , fastboot , lkml , Maneesh Soni , Hariprasad Nellitheertha , suparna bhattacharya In-Reply-To: References: <20050202161108.18D7.ODA@valinux.co.jp> Message-Id: <20050204090151.18F0.ODA@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.10.04 [ja] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 38 Hi, On 02 Feb 2005 07:45:11 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote: > > And the feedback begins :) > > Itsuro Oda writes: > > > Hi, > > > > I don't like calling crash_kexec() directly in (ex.) panic(). > > It should be call_dump_hook() (or something like this). > > > > I think the necessary modifications of the kernel is only: > > - insert the hooks that calls a dump function when crash occur > crash_kexec() > > - binding interface that binds a dump function to the hook > > (like register_dump_hook()) > sys_kexec_load(...); For example there are pepole who want to execute a built in kernel debugger when the system is crashed. or there are pepole who believe the diskdump is the best dump tool :-) So I think a sort of hook is better than calling crash_kexec directly. (May I make a patch ?) Thanks. -- Itsuro ODA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/