Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261780AbVBDGQz (ORCPT ); Fri, 4 Feb 2005 01:16:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263202AbVBDGQz (ORCPT ); Fri, 4 Feb 2005 01:16:55 -0500 Received: from twilight.ucw.cz ([81.30.235.3]:63208 "EHLO suse.cz") by vger.kernel.org with ESMTP id S261780AbVBDGQn (ORCPT ); Fri, 4 Feb 2005 01:16:43 -0500 Date: Fri, 4 Feb 2005 07:17:03 +0100 From: Vojtech Pavlik To: Peter Osterlund Cc: Pete Zaitcev , linux-kernel@vger.kernel.org, dtor_core@ameritech.net Subject: Re: Touchpad problems with 2.6.11-rc2 Message-ID: <20050204061703.GB2329@ucw.cz> References: <20050123190109.3d082021@localhost.localdomain> <20050201234148.4d5eac55@localhost.localdomain> <20050202141117.688c8dd3@localhost.localdomain> <20050203064645.GA2342@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2352 Lines: 58 On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: > Vojtech Pavlik writes: > > > On Wed, Feb 02, 2005 at 11:58:05PM +0100, Peter Osterlund wrote: > > > > > In practice I don't think it will make any significant difference. What > > > the code should do depends on what you want to happen if you move the > > > mouse pointer 1/2 pixel with one finger stroke, then move it another 1/2 > > > pixel with a second stroke. The patch I posted will move the pointer one > > > pixel in this case and your code will move it 0 pixels. (The X driver does > > > not reset the fractions, but that doesn't of course mean that it's the > > > only right thing to do.) > > > > > > > Also, I think the extra unary minus is uncoth. > > > > > > The code was written like that to emphasize the fact that X and Y use the > > > same formula, with the only difference that the kernel Y axis is mirrored > > > compared to the touchpad Y axis. > > > > > > It didn't make any difference for the generated assembly code though, > > > using gcc 3.4.2 from Fedora Core 3. > > > > > > > + enum { FRACTION_DENOM = 100 }; > > > > > > The enum is much nicer than my #define. > > > > OK. I like this patch, too. Can you guys send me a final version > > incorporating the changes of you both for inclusion in the input tree? > > Here it is, with the suggestions from Pete and Dmitry included. The > patch does the following: > > * Compensates for the lack of floating point arithmetic by keeping > track of remainders from the integer divisions. This was likely the main cause of the slow motion problems. > * Removes the xres/yres scaling so that you get the same speed in the > X and Y directions even if your screen is not square. The old code assumed that both the pad and the screen are 4:3, not square. It was wrong still. > * Sets scale factors to make the speed for synaptics and alps equal to > each other and equal to the synaptics speed from 2.6.10. > > Signed-off-by: Peter Osterlund OK. I'll add it to my tree today. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/