To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Updated FAT attributes patch
References: <4202741F.9040102@zytor.com>
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: Fri, 04 Feb 2005 21:42:41 +0900
In-Reply-To: <4202741F.9040102@zytor.com> (H. Peter Anvin's message of "Thu,
 03 Feb 2005 10:57:35 -0800")
Message-ID: <87hdkswl6m.fsf@devron.myhome.or.jp>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1106
Lines: 35

"H. Peter Anvin" <hpa@zytor.com> writes:

> This updates the FAT attributes as well as (hopefully) corrects the
> handling of VFAT ctime.  The FAT attributes are implemented as a
> 32-bit ioctl, per the previous discussions.

[...]

> +		/* This MUST be done before doing anything irreversible... */
> +		if ( (err = notify_change(filp->f_dentry, &ia)) )
> +			goto up;
> +		
> +		if (sbi->options.sys_immutable) {
> +			if ( attr & ATTR_SYS )
> +				inode->i_flags |= S_IMMUTABLE;
> +			else
> +				inode->i_flags &= S_IMMUTABLE;
> +		}
> +
> +		MSDOS_I(inode)->i_attrs = attr & ATTR_UNUSED;

Looks good to me. However, we would need to add the mark_inode_ditry()
after seting iattr. Because another write_inode() path can clear the
dirty flag before setting ->i_attr.

I'll apply the patch and add it.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/