Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264880AbVBDVA7 (ORCPT ); Fri, 4 Feb 2005 16:00:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263697AbVBDUzK (ORCPT ); Fri, 4 Feb 2005 15:55:10 -0500 Received: from mail.kroah.org ([69.55.234.183]:40372 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S266555AbVBDUwh (ORCPT ); Fri, 4 Feb 2005 15:52:37 -0500 Date: Fri, 4 Feb 2005 12:52:26 -0800 From: Greg KH To: Kylene Hall Cc: linux-kernel@vger.kernel.org, emilyr@us.ibm.com, toml@us.ibm.com, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] tpm: implement use of sysfs classes Message-ID: <20050204205226.GA26780@kroah.com> References: <29495f1d041221085144b08901@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 18 On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote: > +static struct class tpm_class = { > + .name = "tpm", > + .class_dev_attrs = tpm_attrs, > +}; Where is your release function? Did you see any warnings from the kernel when you removed any of these class devices? Why did you ignore it? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/