Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266145AbVBDVwh (ORCPT ); Fri, 4 Feb 2005 16:52:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266453AbVBDVtR (ORCPT ); Fri, 4 Feb 2005 16:49:17 -0500 Received: from e34.co.us.ibm.com ([32.97.110.132]:49912 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S264485AbVBDVhd (ORCPT ); Fri, 4 Feb 2005 16:37:33 -0500 Subject: Re: [PATCH 1/1] tpm: implement use of sysfs classes From: Kylene Hall To: Greg KH Cc: linux-kernel@vger.kernel.org, Emily Ratliff , Tom Lendacky , tpmdd-devel@lists.sourceforge.net In-Reply-To: <20050204205226.GA26780@kroah.com> References: <29495f1d041221085144b08901@mail.gmail.com> <20050204205226.GA26780@kroah.com> Content-Type: text/plain Message-Id: <1107553040.22140.30.camel@jo.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 04 Feb 2005 15:37:20 -0600 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 34 On Fri, 2005-02-04 at 14:52, Greg KH wrote: > On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote: > > +static struct class tpm_class = { > > + .name = "tpm", > > + .class_dev_attrs = tpm_attrs, > > +}; > > Where is your release function? Did you see any warnings from the > kernel when you removed any of these class devices? Why did you ignore > it? > Sorry, I missed the warning message. I have looked at some other instances for what I might need to put in that function and I'm stumped. I didn't kmalloc my class_device structure so I don't need to kfree it. I am using this mechanism so that my sysfs stuff is in a predictable place. It is also very convient how the driver and device links as well as all my class specific files get created for me in the register and likewise removed in the unregister. I call the register from the pci probe path and the unregister from the pci remove path. What might I need to put in this function? Thanks, Kylie > thanks, > > greg k-h > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/