From: Tom Zanussi <zanussi@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16899.62896.559319.678176@tut.ibm.com>
Date: Fri, 4 Feb 2005 16:22:40 -0600
To: Andi Kleen <ak@muc.de>
Cc: Tom Zanussi <zanussi@us.ibm.com>,
       linux-kernel <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>,
       Andrew Morton <akpm@osdl.org>, Roman Zippel <zippel@linux-m68k.org>,
       Robert Wisniewski <bob@watson.ibm.com>, Tim Bird <tim.bird@AM.SONY.COM>,
       karim@opersys.com
Subject: Re: [PATCH] relayfs redux, part 3
In-Reply-To: <20050204221230.GA97506@muc.de>
References: <16899.55393.651042.627079@tut.ibm.com>
	<20050204221230.GA97506@muc.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 32

Andi Kleen writes:
 > 
 > > +
 > > +	local_irq_save(flags);
 > > +	if (unlikely(buf->offset + length > chan->subbuf_size))
 > > +		length = relay_switch_subbuf(buf, length);
 > > +	memcpy(buf->data + buf->offset, data, length);
 > > +	buf->offset += length;
 > > +	local_irq_restore(flags);
 > > + 
 > > +	return length;
 > 
 > Is there any useful user case for returning length here? 
 > (e.g. are users likely to handle errors? I doubt it somehow) 
 > 
 > If not I would eliminate it.
 > 

The main reason would be that length would be 0 only if the buffers
were full, so the caller can suspend writing if it sees that, until
e.g. a daemon catches up.

Thanks for your other comments - I'll make those changes in the next
version.

Tom

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/