Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262973AbVBENvD (ORCPT ); Sat, 5 Feb 2005 08:51:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264452AbVBENvC (ORCPT ); Sat, 5 Feb 2005 08:51:02 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:44043 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S263148AbVBENu2 (ORCPT ); Sat, 5 Feb 2005 08:50:28 -0500 Date: Sat, 5 Feb 2005 14:50:26 +0100 From: Adrian Bunk To: "H. Peter Anvin" , Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] add compiler-gcc4.h Message-ID: <20050205135026.GC3129@stusta.de> References: <20050130130308.GK3185@stusta.de> <41FCFED4.1070301@tiscali.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 45 On Thu, Feb 03, 2005 at 01:04:46AM +0000, H. Peter Anvin wrote: > Followup to: <41FCFED4.1070301@tiscali.de> > By author: Matthias-Christian Ott > In newsgroup: linux.dev.kernel > > > > Hi! > > But maybe gcc 4 will get different later, so I think this patch makes sense. > > > > No, it doesn't. You fork when you have a reason. Eager forking is > *BAD*. As I already said in this thread: The currently used file for gcc 4 is compiler-gcc+.h, not compiler-gcc3.h . And the current setup is to have one file for every major number of gcc. I have no strong opinion whether this approach or the approach of one file for all gcc versions is better - but with the current approach, everything else than a separate file for gcc 4 wasn't logical. I can offer the following choices: - please apply this compiler-gcc4.h patch - let me send a patch merging all compiler-gcc*.h files into one compiler-gcc.h file - let me send a patch merging all compiler-gcc*.h files back into compiler.h > -hpa cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/