DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=Jl3wDbxuJoOnwQxys93h23veaAzm6ryB44KfWrTVCEsWw2owSJZmwQGuulPcadpJRwE5q1X7v2TUoBLCZ0w2AR44ty3eAqLU8zuOYO5HcDkCy+1m888cGTe9xzAJYEWcoGRsKxk92hZ4+1MikcbKw0IN3qDv5m7ROvfXUEIeilc=
Message-ID: <d4b385205020709515d579934@mail.gmail.com>
Date: Mon, 7 Feb 2005 18:51:46 +0100
From: Mikkel Krautz <krautz@gmail.com>
Reply-To: Mikkel Krautz <krautz@gmail.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
In-Reply-To: <20050207174303.GA3113@ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <20050207154424.GB4742@omnipotens.localhost>
	 <20050207174303.GA3113@ucw.cz>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2416
Lines: 74

Are you talking about the following line?

+		else
+			hid_mousepoll_interval = interval;

If so, I put it there, to fill a tiny gap, i felt was missing.

If no parameter is passed, hid_mousepoll_interval is obviously 0.

If a user, who doesn't pass the parameter to usbhid, reads
'/sys/module/usbhid/parameters/mousepoll', the answer would be "0",
which is incorrect, no?

Thanks,
Mikkel

On Mon, 7 Feb 2005 18:43:03 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> On Mon, Feb 07, 2005 at 04:44:24PM +0100, Mikkel Krautz wrote:
> > And, here's an updated version of hid-core.c:
> >
> > Signed-off-by: Mikkel Krautz <krautz@gmail.com>
> > ---
> > --- clean/drivers/usb/input/hid-core.c
> > +++ dirty/drivers/usb/input/hid-core.c
> > @@ -37,13 +37,20 @@
> >   * Version Information
> >   */
> >
> > -#define DRIVER_VERSION "v2.0"
> > +#define DRIVER_VERSION "v2.01"
> >  #define DRIVER_AUTHOR "Andreas Gal, Vojtech Pavlik"
> >  #define DRIVER_DESC "USB HID core driver"
> >  #define DRIVER_LICENSE "GPL"
> >
> >  static char *hid_types[] = {"Device", "Pointer", "Mouse", "Device", "Joystick",
> >                               "Gamepad", "Keyboard", "Keypad", "Multi-Axis Controller"};
> > +/*
> > + * Module parameters.
> > + */
> > +
> > +static unsigned int hid_mousepoll_interval;
> > +module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644);
> > +MODULE_PARM_DESC(mousepoll, "Polling interval of mice");
> >
> >  /*
> >   * Register a new report for a device.
> > @@ -1695,6 +1702,12 @@
> >               if (dev->speed == USB_SPEED_HIGH)
> >                       interval = 1 << (interval - 1);
> >
> > +             /* Change the polling interval of mice. */
> > +             if (hid->collection->usage == HID_GD_MOUSE && hid_mousepoll_interval > 0)
> > +                     interval = hid_mousepoll_interval;
> > +             else
> > +                     hid_mousepoll_interval = interval;
> 
> This line is trying to achieve what?
> 
> > +
> >               if (endpoint->bEndpointAddress & USB_DIR_IN) {
> >                       if (hid->urbin)
> >                               continue;
> >
> >
> 
> --
> Vojtech Pavlik
> SuSE Labs, SuSE CR
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/