Subject: Re: [PATCH] raw1394 : Fix hang on unload
From: Parag Warudkar <kernel-stuff@comcast.net>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
In-Reply-To: <1107872677l.6054l.0l@werewolf.able.es>
References: <1107718875.4378.25.camel@localhost.localdomain>
	 <20050207101914.GA16686@hugang.soulinfo.com>
	 <1107872677l.6054l.0l@werewolf.able.es>
Content-Type: text/plain
Date: Tue, 08 Feb 2005 11:40:52 -0500
Message-Id: <1107880852.4154.6.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 22

> I looked also at other 1394 drivers and all have the calls in 'bad' order.
> Sure this ordering has to be reversed or it is correct and is triggering
> other hidden bug ?
> 
Quite possibly it's triggering (or is triggered by) some other bug. 
There is also a possibility that raw1394.c might be doing something
wrong and gets away with it with the changed ordering. Because dv1394.c
does it the "seemingly-bad" way and I haven't got rmmod to hang while
removing it.

Can anyone answer this - in what  cases will generic_delete_inode hang
on __down_failed -> default_wake_function -> __down?

Thanks

Parag

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/