Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261699AbVBHXx7 (ORCPT ); Tue, 8 Feb 2005 18:53:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261700AbVBHXx7 (ORCPT ); Tue, 8 Feb 2005 18:53:59 -0500 Received: from irulan.endorphin.org ([80.68.90.107]:10245 "EHLO irulan.endorphin.org") by vger.kernel.org with ESMTP id S261699AbVBHXx5 (ORCPT ); Tue, 8 Feb 2005 18:53:57 -0500 Subject: Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm From: Fruhwirth Clemens To: James Morris Cc: Andrew Morton , linux-kernel@vger.kernel.org, michal@logix.cz, "David S. Miller" , "Adam J. Richter" In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 09 Feb 2005 00:53:56 +0100 Message-Id: <1107906836.15942.131.camel@ghanima> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 21 On Tue, 2005-02-08 at 18:30 -0500, James Morris wrote: > On Tue, 8 Feb 2005, Fruhwirth Clemens wrote: > > > I shot out the last patch too quickly. Having reviewed the mapping one > > more time I noticed, that there as the possibility of "off-by-one" > > unmapping, and instead of doing doubtful guesses, if that's the case, I > > added a base pointer to scatter_walk, which is the pointer returned by > > kmap. Exactly this pointer will be unmapped again, so the vaddr > > comparison in crypto_kunmap doesn't have to do any masking. > > You can't call kmap() in softirq context (why was it even trying?): Why not? What's the alternative, then? -- Fruhwirth Clemens http://clemens.endorphin.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/