Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261704AbVBIABa (ORCPT ); Tue, 8 Feb 2005 19:01:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261705AbVBIABa (ORCPT ); Tue, 8 Feb 2005 19:01:30 -0500 Received: from wproxy.gmail.com ([64.233.184.202]:21834 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261704AbVBIABU (ORCPT ); Tue, 8 Feb 2005 19:01:20 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=OvQbQLt8qac7b/TTCDX8JamVJ4Dk/+Apy9jjjlVLl4jZARSz2a39DpxuSdVxeZBTfMih2gijP2Iu9AC2ZKu4E9JSUSMS8DtoBOABVC0dgr0zDOYfV2AxwLG40fw/3nXA4wktjwMIorzhZs6RngHOQRC70lyT7HSqxOJQk7jGB6Y= Message-ID: <58cb370e05020816017431b38@mail.gmail.com> Date: Wed, 9 Feb 2005 01:01:20 +0100 From: Bartlomiej Zolnierkiewicz Reply-To: Bartlomiej Zolnierkiewicz To: "Mark A. Greer" Subject: Re: [PATCH][I2C] Marvell mv64xxx i2c driver Cc: Greg KH , LM Sensors , lkml In-Reply-To: <42094ADB.9040403@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <42094ADB.9040403@mvista.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 30 Hi, just a minor thing > +static int __devinit > +mv64xxx_i2c_init(void) > +{ > + return driver_register(&mv64xxx_i2c_driver); > +} __init > +static void __devexit > +mv64xxx_i2c_exit(void) > +{ > + driver_unregister(&mv64xxx_i2c_driver); > + return; > +} __exit these functions relate to module not device > +module_init(mv64xxx_i2c_init); > +module_exit(mv64xxx_i2c_exit); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/