Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262179AbVBLCCY (ORCPT ); Fri, 11 Feb 2005 21:02:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262381AbVBLCAH (ORCPT ); Fri, 11 Feb 2005 21:00:07 -0500 Received: from siaag1ae.compuserve.com ([149.174.40.7]:2440 "EHLO siaag1ae.compuserve.com") by vger.kernel.org with ESMTP id S262179AbVBLB7X (ORCPT ); Fri, 11 Feb 2005 20:59:23 -0500 Date: Fri, 11 Feb 2005 20:55:15 -0500 From: Chuck Ebbert <76306.1226@compuserve.com> Subject: Re: [PATCH 2.6.11-rc3 06/11] ide: make disk flush functions use TASKFILE instead To: Tejun Heo Cc: Bartlomiej Zolnierkiewicz , Jeff Garzik , linux-ide , linux-kernel Message-ID: <200502112058_MC3-1-95CC-5FF0@compuserve.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 599 Lines: 17 On Thu, 10 Feb 2005 at 17:38:39 +0900, Tejun Heo wrote: > - (drive->capacity64 >= (1UL << 28))) > - rq->buffer[0] = WIN_FLUSH_CACHE_EXT; > + (drive->capacity64 >= (1UL << 28))) { > + task->tfRegister[IDE_COMMAND_OFFSET] = WIN_FLUSH_CACHE_EXT; Shouldn't that be "(drive->capacity64 > (1UL << 28))" ?? -- Chuck - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/