Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261530AbVBNTYe (ORCPT ); Mon, 14 Feb 2005 14:24:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261532AbVBNTYd (ORCPT ); Mon, 14 Feb 2005 14:24:33 -0500 Received: from cantor.suse.de ([195.135.220.2]:11399 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261530AbVBNTYc (ORCPT ); Mon, 14 Feb 2005 14:24:32 -0500 Date: Mon, 14 Feb 2005 20:24:29 +0100 Message-ID: From: Takashi Iwai To: Greg KH Cc: Jeff Garzik , Linux Kernel , Andrew Morton , Alan Cox Subject: Re: avoiding pci_disable_device()... In-Reply-To: <20050214190619.GA9241@kroah.com> References: <4210021F.7060401@pobox.com> <20050214190619.GA9241@kroah.com> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 30 At Mon, 14 Feb 2005 11:06:19 -0800, Greg KH wrote: > > > As a result, I have committed the attached patch to libata-2.6. In many > > cases, it is a "semantic fix", addressing the case > > > > * pci_request_regions() indicates hardware is in use > > * we rudely disable the in-use hardware > > > > that would not occur in practice. > > > > But better safe than sorry. Code cuts cut-n-pasted all over the place. > > > > I'm hoping one or two things will happen now: > > * janitors fix up the other PCI drivers along these lines > > * improve the PCI API so that pci_request_regions() is axiomatic > > Do you have any suggestions for how to do this? How about to add an exclusiveness check in pci_enable_device()? Most drivers suppose that the given pci resources are exclusively available. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/