Date: Tue, 15 Feb 2005 11:51:52 +0100
From: Andi Kleen <ak@suse.de>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>
Subject: Re: fix iounmap and a pageattr memleak (x86 and x86-64)
Message-ID: <20050215105151.GC2623@wotan.suse.de>
References: <20041028192104.GA3454@dualathlon.random> <20041105080716.GL8229@dualathlon.random> <20041105083102.GD16992@wotan.suse.de> <20041105084900.GN8229@dualathlon.random> <20050214231554.GQ13712@opteron.random> <20050215103915.GB2623@wotan.suse.de> <20050215104827.GY13712@opteron.random>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050215104827.GY13712@opteron.random>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 26

On Tue, Feb 15, 2005 at 11:48:27AM +0100, Andrea Arcangeli wrote:
> On Tue, Feb 15, 2005 at 11:39:15AM +0100, Andi Kleen wrote:
> > On Tue, Feb 15, 2005 at 12:15:54AM +0100, Andrea Arcangeli wrote:
> > > Hello,
> > > 
> > > the fix for this bug in 2.6.11-rc3 for this bug is wrong, I thought I
> > 
> > Can you describe what exactly is wrong? 
> 
> the wrong thing is that if I change the size of the guard page in
> vmalloc.c, the arch code will break. the guard page is a debugging knob,
> people may want to remove it someday to save virtual address space, and
> they shouldn't be required to look after N architectures.

Ok, so it is merely a cosmetic issue.

I was worried about an actual bug :)

No problem with changing it, but hopefully after 2.6.11.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/