Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261929AbVBPA2T (ORCPT ); Tue, 15 Feb 2005 19:28:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261958AbVBPA2T (ORCPT ); Tue, 15 Feb 2005 19:28:19 -0500 Received: from mail.kroah.org ([69.55.234.183]:22987 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261929AbVBPA2P (ORCPT ); Tue, 15 Feb 2005 19:28:15 -0500 Date: Tue, 15 Feb 2005 15:44:15 -0800 From: Greg KH To: dtor_core@ameritech.net Cc: Kay Sievers , linux-kernel@vger.kernel.org Subject: Re: [PATCH] add "bus" symlink to class/block devices Message-ID: <20050215234415.GA17680@kroah.com> References: <20050215205344.GA1207@vrfy.org> <20050215220406.GA1419@vrfy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 32 On Tue, Feb 15, 2005 at 05:25:54PM -0500, Dmitry Torokhov wrote: > On Tue, 15 Feb 2005 23:04:06 +0100, Kay Sievers wrote: > > > > -static int class_device_dev_link(struct class_device * class_dev) > > -{ > > - if (class_dev->dev) > > - return sysfs_create_link(&class_dev->kobj, > > - &class_dev->dev->kobj, "device"); > > - return 0; > > -} > > - > > -static void class_device_dev_unlink(struct class_device * class_dev) > > -{ > > - sysfs_remove_link(&class_dev->kobj, "device"); > > -} > > - > > Hi, > > I can agree on dropping driver link but I think that the link to > underlying real device is still needed. It's still there, read the patch :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/