To: oda@valinux.co.jp
Cc: ebiederm@xmission.com, fastboot@lists.osdl.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /proc/cpumem
In-Reply-To: Your message of "Wed, 16 Feb 2005 17:49:51 +0900"
	<20050216170224.4C66.ODA@valinux.co.jp>
References: <20050216170224.4C66.ODA@valinux.co.jp>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Date: Thu, 17 Feb 2005 09:17:15 +0900
Message-Id: <1108599435.484439.5660.nullmailer@yamt.dyndns.org>
From: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 809
Lines: 32

hi,

> +	while (addr < end) {
> +		if (valid_phys_addr_range(addr, &size)) {
> +			if (!found) {
> +				found = 1;
> +				p->addr = addr;
> +				p->size = size;
> +			} else {
> +				p->size += size;
> +			}
> +			addr += size;
> +			size = 0xf0000000;
> +		} else {
> +			if (found) {
> +				return p;
> +			}
> +			addr += PAGE_SIZE;
> +		}
> +	}

doesn't this loop take very long time if you have a large hole?

i'd suggest to change valid_phys_addr_range to fill &size even when
it returns false, so that caller can skip the hole efficiently.

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/