Date: Sat, 19 Feb 2005 14:37:11 -0800
From: Greg KH <greg@kroah.com>
To: Mickey Stein <yekkim@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c.h: Fix another gcc 4.0 compile failure
Message-ID: <20050219223711.GB12713@kroah.com>
References: <42177048.2000109@pacbell.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42177048.2000109@pacbell.net>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 38

On Sat, Feb 19, 2005 at 08:58:48AM -0800, Mickey Stein wrote:
> From: Mickey Stein
>  Versions:   linux-2.6.11-rc4-bk7, gcc4 (GCC) 4.0.0 20050217 (latest fc 
> rawhide from 19Feb DL)
> 
>  gcc4 cvs seems to dislike "include/linux/i2c.h file":
> 
>  Error msg:   include/linux/i2c.h:{55,194} error: array type has 
> incomplete element type
> 
>  A. Daplas has recently done a workaround for this on another header 
> file. A thread discussing this
>  can be found by following the link below:
> 
>  http://gcc.gnu.org/ml/gcc/2005-02/msg00053.html
> 
>  The patch changes the array declaration from "struct x y[]" format to 
> "struct x *y".
>  I realize its only a workaround, but the gcc guys seem to be aware of 
> this.
>  ** Note: I'm a noob at this, so feel free to make chopped liver out of 
> this if its incorrect.
>  patch below is also attached since I'm not sure formatting survives 
> the cut&paste.

The patch looks sane, but before I apply it, care to also fix up all of
the function pointers that are affected by this patch?  Also the
i2c_transfer() function itself should be changed (not just the header
file.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/