Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261362AbVBWA3j (ORCPT ); Tue, 22 Feb 2005 19:29:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261365AbVBWA3j (ORCPT ); Tue, 22 Feb 2005 19:29:39 -0500 Received: from relay.axxeo.de ([213.239.199.237]:20631 "EHLO relay.axxeo.de") by vger.kernel.org with ESMTP id S261362AbVBWA3h (ORCPT ); Tue, 22 Feb 2005 19:29:37 -0500 From: Ingo Oeser To: Linux Kernel ML Subject: Re: [Patch 4/6] Bind Mount Extensions 0.06 Date: Wed, 23 Feb 2005 01:29:30 +0100 User-Agent: KMail/1.7.1 References: <20050222121233.GE3682@mail.13thfloor.at> In-Reply-To: <20050222121233.GE3682@mail.13thfloor.at> Cc: Andrew Morton , Al Viro MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200502230129.30225.ioe-lkml@axxeo.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 23 Hi, Herbert Poetzl wrote: > +static inline int mnt_may_unlink(struct vfsmount *mnt, struct inode *dir, > struct dentry *child) { + if (!child->d_inode) > + return -ENOENT; > + if (MNT_IS_RDONLY(mnt)) > + return -EROFS; > + return 0; > +} The argument "dir" is not used. Please remove it and fix the callers. Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/