Subject: Re: [PATCH] Fix for broken kexec on panic
From: Dave Hansen <haveblue@us.ibm.com>
To: Vivek Goyal <vgoyal@in.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>, fastboot <fastboot@lists.osdl.org>,
       Andrew Morton <akpm@osdl.org>,
       "Eric W. Biederman" <ebiederm@xmission.com>
In-Reply-To: <1109236432.5148.192.camel@terminator.in.ibm.com>
References: <1109236432.5148.192.camel@terminator.in.ibm.com>
Content-Type: text/plain
Date: Thu, 24 Feb 2005 07:35:15 -0800
Message-Id: <1109259315.7244.49.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1245
Lines: 28

On Thu, 2005-02-24 at 14:43 +0530, Vivek Goyal wrote:
> Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of
> re-organization of boot memory allocator initialization code.  Primary
> kernel does not boot if kexec is enabled and crashkernel=X@Y command
> line parameter is passed. After re-organization, kexec is trying to call
> reserve_bootmem before boot memory allocator has initialized.
> 
> This patch fixes the problem. I have moved the call to
> reserved_bootmem() for kexec for both discontig and contig memory into
> new setup_bootmem_allocator().
> 
> This patch has been generated against 2.6.11-rc4-mm1

Looks like a good change, especially since it reduces the total amount
of code (and the size of your patch).

Although, to make any potential merging easier, it is almost always
better to put those kinds of things in functions #ifdef'd in a header.
The fact that there are other #ifdefs in setup_bootmem_allocator() is a
partial excuse, but not a very good one. :)

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/