Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262520AbVBYFDn (ORCPT ); Fri, 25 Feb 2005 00:03:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262513AbVBYFDn (ORCPT ); Fri, 25 Feb 2005 00:03:43 -0500 Received: from ozlabs.org ([203.10.76.45]:10660 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S262520AbVBYFDU (ORCPT ); Fri, 25 Feb 2005 00:03:20 -0500 Date: Fri, 25 Feb 2005 16:03:10 +1100 From: David Gibson To: Jeff Garzik Cc: Dominik Brodowski , Pavel Roskin , Orinoco Development List , netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [Orinoco-devel] Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups Message-ID: <20050225050310.GF10725@localhost.localdomain> Mail-Followup-To: Jeff Garzik , Dominik Brodowski , Pavel Roskin , Orinoco Development List , netdev@oss.sgi.com, linux-kernel@vger.kernel.org References: <20050224035445.GB32001@localhost.localdomain> <20050224035524.GC32001@localhost.localdomain> <20050224035650.GD32001@localhost.localdomain> <20050224035718.GE32001@localhost.localdomain> <20050224035804.GF32001@localhost.localdomain> <20050224035957.GH32001@localhost.localdomain> <20050224040024.GI32001@localhost.localdomain> <20050224040052.GJ32001@localhost.localdomain> <20050224065527.GA8931@isilmar.linta.de> <421D8241.9020608@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <421D8241.9020608@pobox.com> User-Agent: Mutt/1.5.6+20040523i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 47 On Thu, Feb 24, 2005 at 02:29:05AM -0500, Jeff Garzik wrote: > Dominik Brodowski wrote: > >>@@ -184,6 +186,7 @@ > >> dev_list = link; > >> > >> client_reg.dev_info = &dev_info; > >>+ client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; > > > > > >That's not needed any longer for 2.6. > > So who wants to send the incremental update patch? :) Guess I will. See below. Any particular reason the field and associated constants haven't been exunged from the tree, since they're no longer used? The client_reg.Attributes field is no longer used. Don't bother setting it. Signed-off-by: David Gibson Index: working-2.6/drivers/net/wireless/orinoco_cs.c =================================================================== --- working-2.6.orig/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:47:53.098405968 +1100 +++ working-2.6/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:52:56.000000000 +1100 @@ -186,7 +186,6 @@ dev_list = link; client_reg.dev_info = &dev_info; - client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; client_reg.EventMask = CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL | CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET | -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist. NOT _the_ _other_ _way_ | _around_! http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/