Subject: Re: [2.6 patch] unexport do_settimeofday
From: Arjan van de Ven <arjan@infradead.org>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
       Andrew Morton <akpm@osdl.org>, bunk@stusta.de,
       linux-kernel@vger.kernel.org
In-Reply-To: <20050225092640.GS27352@schnapps.adilger.int>
References: <20050224233742.GR8651@stusta.de>
	 <20050224212448.367af4be.akpm@osdl.org>
	 <1109318525.6290.32.camel@laptopd505.fenrus.org>
	 <20050225002804.4905b649.akpm@osdl.org>
	 <58cb370e050225004759e1dc59@mail.gmail.com>
	 <20050225092640.GS27352@schnapps.adilger.int>
Content-Type: text/plain
Date: Fri, 25 Feb 2005 10:33:37 +0100
Message-Id: <1109324017.6290.38.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1314
Lines: 30

On Fri, 2005-02-25 at 02:26 -0700, Andreas Dilger wrote:
> On Feb 25, 2005  09:47 +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Fri, 25 Feb 2005 00:28:04 -0800, Andrew Morton <akpm@osdl.org> wrote:
> > > Adrian Bunk <bunk@stusta.de> wrote:
> > > >  I haven't found any possible modular usage of do_settimeofday in the
> > > >  kernel.
> > > 
> > > Sure.  But there must have been a reason to export it in the first place.
> > 
> > sloppy coding?
> 
> Who knows?  Maybe someone developed a kernel module that interfaces to an
> unusual clock chip on their motherboard.  IMHO, all of this "_I_ don't
> see any use for it, lets get rid of it because it's not useful" changing
> is just a source of grief for anyone that doesn't have their code in
> the kernel.

actually exports cause kernels to be bigger. Some of these exports
aren't even used in the kernel entirely, others cause the kernel to be
bigger just by being non-static and having the symbol structures there.
A lot of them are "you really shouldn't" APIs.

By your argument, why bother with exports at all?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/