Date: Fri, 25 Feb 2005 09:11:22 -0800
From: Chris Wright <chrisw@osdl.org>
To: Darren Hart <dvhltc@us.ibm.com>
Cc: "lkml, " <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vm: mlock superfluous variable
Message-ID: <20050225171122.GE28536@shell0.pdx.osdl.net>
References: <421E74B5.3040701@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <421E74B5.3040701@us.ibm.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 21

* Darren Hart (dvhltc@us.ibm.com) wrote:
> The were a couple long standing (since at least 2.4.21) superfluous 
> variables and two unnecessary assignments in do_mlock().  The intent of 
> the resulting code is also more obvious.
> 
> Tested on a 4 way x86 box running a simple mlock test program.  No 
> problems detected.

Did you test with multiple page ranges, and locking subsets of vmas?
Seems that splitting could cause a problem since you now sample vm_end
before and after fixup, where the vma could be changed in the middle.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/