Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261448AbVBZDl1 (ORCPT ); Fri, 25 Feb 2005 22:41:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261411AbVBZDlN (ORCPT ); Fri, 25 Feb 2005 22:41:13 -0500 Received: from fire.osdl.org ([65.172.181.4]:3046 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261406AbVBZDlH (ORCPT ); Fri, 25 Feb 2005 22:41:07 -0500 Date: Fri, 25 Feb 2005 19:42:00 -0800 (PST) From: Linus Torvalds To: Marcelo Tosatti cc: nuclearcat , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: pty_chars_in_buffer NULL pointer (kernel oops) In-Reply-To: <20050225230432.GD15251@logos.cnet> Message-ID: References: <1567604259.20050218105653@nuclearcat.com> <20050225230432.GD15251@logos.cnet> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 21 On Fri, 25 Feb 2005, Marcelo Tosatti wrote: > > BTW, I fail to see any drivers/char/pty.c change related to the race which triggers > the pty_chars_in_buffer->0 oops. Indeed, I don't think 2.6.x got that merged, because it was never really clear _which_ fix was the right one (the extra locking was absolutely deadly for performance, the hacky one was a tad _too_ hacky ;) Alan, did you ever decide what the proper locking would be? I've applied the hacky "works by hiding the problem" patch for 2.6.11 which didn't have any subtle performance issues associated with it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/