Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261295AbVBZXlH (ORCPT ); Sat, 26 Feb 2005 18:41:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261296AbVBZXlH (ORCPT ); Sat, 26 Feb 2005 18:41:07 -0500 Received: from hera.cwi.nl ([192.16.191.8]:64725 "EHLO hera.cwi.nl") by vger.kernel.org with ESMTP id S261295AbVBZXlD (ORCPT ); Sat, 26 Feb 2005 18:41:03 -0500 Date: Sun, 27 Feb 2005 00:40:53 +0100 From: Andries Brouwer To: Linus Torvalds Cc: Andries Brouwer , Uwe Bonnes , akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] partitions/msdos.c Message-ID: <20050226234053.GA14236@apps.cwi.nl> References: <20050226213459.GA21137@apps.cwi.nl> <16928.62091.346922.744462@hertz.ikp.physik.tu-darmstadt.de> <20050226225203.GA25217@apps.cwi.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1621 Lines: 40 On Sat, Feb 26, 2005 at 03:12:28PM -0800, Linus Torvalds wrote: > > The default fdisk will assign type 83 to a newly created partition. > > Ok. Is that a "it has done so for the last 5 years" thing? The last twelve years. > > (About type 0: DOS has used type 0 as definition of unused. It is not > > bad if Linux uses DOS-conventions for a DOS-type partition table.) > > Agreed. At the same time, I could well imagine that some people might use > such a type exactly to make DOS ignore it (but I assume the same is true > of the regular 0x83 type too, so maybe I'm just being difficult). > > There's certainly a good argument for fixing a known problem (Uwe) and a > small enough risk of it breaking anything else. Yes. Andries (Concerning the "size" version: it occurred to me that there is one very minor objection: For extended partitions so far the size did not normally play a role. Only the starting sector was significant. If, at some moment we decide also to check the size, then a weaker check, namely only checking for non-extended partitions, might be better at first.) (Yes, disk capacity is not always known - see e.g. ll_rw_blk.c: /* Test device or partition size, when known. */ See also sd.c, with the strange sdkp->capacity = 0x200000; /* 1 GB - random */ In such cases we just access the blocks user space tells us to access.) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/