Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261544AbVB1DWm (ORCPT ); Sun, 27 Feb 2005 22:22:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261541AbVB1DWf (ORCPT ); Sun, 27 Feb 2005 22:22:35 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:34781 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261540AbVB1DW1 (ORCPT ); Sun, 27 Feb 2005 22:22:27 -0500 Date: Mon, 28 Feb 2005 03:22:20 +0000 From: Christoph Hellwig To: Jeff Garzik Cc: Wen Xiong , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Andrew Morton , Greg KH Subject: Re: [ patch 6/7] drivers/serial/jsm: new serial device driver Message-ID: <20050228032220.GB5300@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeff Garzik , Wen Xiong , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Andrew Morton , Greg KH References: <42225A64.6070904@us.ltcfwd.linux.ibm.com> <42226A3E.6000707@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42226A3E.6000707@pobox.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 17 On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote: > >+struct shrink_buf_struct { > >+ unsigned int shrink_buf_vaddr; /* Virtual address of board > >*/ > >+ unsigned int shrink_buf_phys; /* Physical address of board > >*/ > > Major bug. These should be unsigned long. not sure what they actually mean, but a virtual address should be a void * and drivers shouldn't ever mess with physical addresses. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/