Date: Sun, 27 Feb 2005 21:39:46 -0800
From: Andrew Morton <akpm@osdl.org>
To: "" <pmarques@grupopie.com>
Cc: mdharm-kernel@one-eyed-alien.net, linux-kernel@vger.kernel.org,
       perex@suse.cz, luming.yu@intel.com
Subject: Re: sizeof(ptr) or sizeof(*ptr)?
Message-Id: <20050227213946.199e82af.akpm@osdl.org>
In-Reply-To: <1109546013.4222541d5db16@webmail.grupopie.com>
References: <1109535904.42222ca0b0b78@webmail.grupopie.com>
	<20050227204524.GA29026@one-eyed-alien.net>
	<1109546013.4222541d5db16@webmail.grupopie.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 29

"" <pmarques@grupopie.com> wrote:
>
> Anyway, after improving the tool and checking for false positives, there is only
>  one more suspicious piece of code in drivers/acpi/video.c:561
> 
>  	status = acpi_video_device_lcd_query_levels(device, &obj);
> 
>  	if (obj && obj->type == ACPI_TYPE_PACKAGE && obj->package.count >= 2) {
>  		int count = 0;
>  		union acpi_object *o;
> 
>  		br = kmalloc(sizeof &br, GFP_KERNEL);

yup, bug.

>  		if (!br) {
>  			printk(KERN_ERR "can't allocate memory\n");
>  		} else {
>  			memset(br, 0, sizeof &br);
>  			br->levels = kmalloc(obj->package.count * sizeof &br->levels, GFP_KERNEL);

And another one, although it happens to work out OK.

I'll get these all fixed up, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/