Message-ID: <42247EF0.9000404@adaptec.com>
Date: Tue, 01 Mar 2005 09:40:48 -0500
From: Luben Tuikov <luben_tuikov@adaptec.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: dougg@torque.net
CC: Adrian Bunk <bunk@stusta.de>, James.Bottomley@SteelEye.com,
       linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SCSI: possible cleanups
References: <20050228213159.GO4021@stusta.de> <4224245E.6090503@torque.net>
In-Reply-To: <4224245E.6090503@torque.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 890
Lines: 26

On 03/01/05 03:14, Douglas Gilbert wrote:
>>   - scsi_error.c: scsi_normalize_sense
> 
> 
> I introduced scsi_normalize_sense() recently, Christoph H.
> proposed it should be static but Luben Tuikov (aic7xxx
> maintainer) said he wished to use it in the future.
> Hence it was left global.

Hi guys,

I think the idea of normalized sense is very good.
Basically the question is if LLDD would submit normalized
sense to SCSI Core or whether they would submit a pointer
to raw sense data as returned by the device and let SCSI
Core decipher it.

If the former, then it should be global, if the latter then
it should be static to SCSI Core.

	Luben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/