Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262719AbVCCXQd (ORCPT ); Thu, 3 Mar 2005 18:16:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262714AbVCCW7K (ORCPT ); Thu, 3 Mar 2005 17:59:10 -0500 Received: from nibbel.kulnet.kuleuven.ac.be ([134.58.240.41]:4026 "EHLO nibbel.kulnet.kuleuven.ac.be") by vger.kernel.org with ESMTP id S262685AbVCCW4t (ORCPT ); Thu, 3 Mar 2005 17:56:49 -0500 From: "Panagiotis Issaris" Date: Thu, 3 Mar 2005 23:55:09 +0100 To: Jody McIntyre Cc: dtor_core@ameritech.net, Anton Altaparmakov , lkml , linux1394-devel@lists.sourceforge.net Subject: Re: [PATCH] raw1394 missing failure handling Message-ID: <20050303225509.GB7442@mech.kuleuven.ac.be> References: <4225CDEF.4070501@mech.kuleuven.ac.be> <20050303214843.GQ1111@conscoop.ottawa.on.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050303214843.GQ1111@conscoop.ottawa.on.ca> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1712 Lines: 51 Hi Jody, My previous e-mail seemed to be messed up by Thunderbird... so now I'm using good old Mutt again. On Thu, Mar 03, 2005 at 04:48:43PM -0500 or thereabouts, Jody McIntyre wrote: > > Thanks. Here's my third try :-) > > > > With friendly regards, > > Takis > > I'll apply this to the 1394 tree and send it to Linus after testing if > you add a Signed-off-by: line per Documentation/SubmittingPatches . > Also, please cc linux1394-devel@lists.sourceforge.net with ieee1394 > changes. Sure! Thanks! Adds the missing failure handling for a __copy_to_user call. Signed-off-by: Panagiotis Issaris diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c linux-2.6.11-pi/drivers/ieee1394/raw1394.c --- linux-2.6.11/drivers/ieee1394/raw1394.c 2005-03-02 11:44:26.000000000 +0100 +++ linux-2.6.11-pi/drivers/ieee1394/raw1394.c 2005-03-02 15:27:15.000000000 +0100 @@ -443,7 +443,10 @@ static ssize_t raw1394_read(struct file req->req.error = RAW1394_ERROR_MEMFAULT; } } - __copy_to_user(buffer, &req->req, sizeof(req->req)); + if (__copy_to_user(buffer, &req->req, sizeof(req->req))) { + free_pending_request(req); + return -EFAULT; + } free_pending_request(req); return sizeof(struct raw1394_request); -- K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group http://people.mech.kuleuven.ac.be/~pissaris/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/