Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262623AbVCDKke (ORCPT ); Fri, 4 Mar 2005 05:40:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262718AbVCDKke (ORCPT ); Fri, 4 Mar 2005 05:40:34 -0500 Received: from wproxy.gmail.com ([64.233.184.195]:58730 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S262623AbVCDKkJ (ORCPT ); Fri, 4 Mar 2005 05:40:09 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=n4gE+8g04bupwvU7tcWLXwylmMHukuPX8v+l4Pkrqnmm8iZLzm6uXiLM5Kqr2SIZCzN7GJ9/IYAQ5SuzQ3wO+3KxMY5fCZX9R6MV4tuxX+NqbhKtCTHTmoZjh8mz1RvFXV66nPNGYpHsTDybyROmho+1mTJZH+ttVCJYcO6vzJA= Message-ID: <58cb370e0503040240314120ea@mail.gmail.com> Date: Fri, 4 Mar 2005 11:40:08 +0100 From: Bartlomiej Zolnierkiewicz Reply-To: Bartlomiej Zolnierkiewicz To: Mike Waychison Subject: Re: [2.6 patch] unexport complete_all Cc: Adrian Bunk , Linux kernel , Andrew Morton In-Reply-To: <422817C3.2010307@waychison.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <422817C3.2010307@waychison.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 43 On Fri, 04 Mar 2005 03:09:39 -0500, Mike Waychison wrote: > > I didn't find any possible modular usage in the kernel. > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 01:04:28.000000000 +0100 > > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c 2005-03-04 01:04:34.000000000 +0100 > > @@ -3053,7 +3053,6 @@ > > 0, 0, NULL); > > spin_unlock_irqrestore(&x->wait.lock, flags); > > } > > -EXPORT_SYMBOL(complete_all); > > > > void fastcall __sched wait_for_completion(struct completion *x) > > { > > - > > This is a valid piece of API that is exported for future use. Let me guess: autofsng? It was you who added it (through akpm): [PATCH] export complete_all() From: Mike Waychison Export complete_all for module use. Andrew, what is the policy for adding exports for out of tree GPL code? IMHO although it is convenient for maintainers of such code it is inconvenient for us (ie. when making changes to code) and gives people false assumptions about stability of *in-kernel* APIs. Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/