Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262875AbVCDLP5 (ORCPT ); Fri, 4 Mar 2005 06:15:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262844AbVCDLL7 (ORCPT ); Fri, 4 Mar 2005 06:11:59 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:530 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S262772AbVCDLF7 (ORCPT ); Fri, 4 Mar 2005 06:05:59 -0500 Date: Fri, 4 Mar 2005 12:05:56 +0100 From: Adrian Bunk To: Mike Waychison Cc: Linux kernel Subject: Re: [2.6 patch] unexport complete_all Message-ID: <20050304110556.GC3992@stusta.de> References: <422817C3.2010307@waychison.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <422817C3.2010307@waychison.com> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 43 On Fri, Mar 04, 2005 at 03:09:39AM -0500, Mike Waychison wrote: > > I didn't find any possible modular usage in the kernel. > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 01:04:28.000000000 +0100 > > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c 2005-03-04 01:04:34.000000000 +0100 > > @@ -3053,7 +3053,6 @@ > > 0, 0, NULL); > > spin_unlock_irqrestore(&x->wait.lock, flags); > > } > > -EXPORT_SYMBOL(complete_all); > > > > void fastcall __sched wait_for_completion(struct completion *x) > > { > > - > > This is a valid piece of API that is exported for future use. >... You exported this function nearly one year ago with the only comment "Export complete_all for module use.". Why did you add the export last year instead of simply adding it when it will be required? > Mike Waychison cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/