DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=I4/ExA8BWVxPEEDRE6Nm4kRvy3qEYINg6WLrxpQngGD2c1KP+g/oJkYNCOxYu5zkMS1eRz6SZjhWSqTkqzUbiz8en0RdFc44pngNYm8OH7NKfiuGu2AI/fwDvH8dRrlsUgzryLx+D8EUGFwjFV19ERkPiWyn3AjRaClna9e75oI=
Message-ID: <58cb370e050304051424b29c3d@mail.gmail.com>
Date: Fri, 4 Mar 2005 14:14:39 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Reply-To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Subject: Re: [2.6 patch] unexport complete_all
Cc: mike@waychison.com, bunk@stusta.de, linux-kernel@vger.kernel.org
In-Reply-To: <20050304031504.4ea49f83.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <422817C3.2010307@waychison.com>
	 <58cb370e0503040240314120ea@mail.gmail.com>
	 <20050304031504.4ea49f83.akpm@osdl.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1317
Lines: 32

On Fri, 4 Mar 2005 03:15:04 -0800, Andrew Morton <akpm@osdl.org> wrote:
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> >
> > Andrew, what is the policy for adding exports for out of tree GPL code?
> >
> 
> There isn't one.  Such things cause way too much email.

Lack of policy causes the same thing (ie. this thread).

> What complete_all() does is to permit more than one task to wait on a
> completion and for all those tasks to be woken by a single complete().
> Without it you'd need to record how many tasks are sleeping there and do
> complete() that many times.
> 
> So it's a sensible part of the completion API from a regularity-of-the-API

This function was already part of in-kernel API, just wasn't exported
for modules because there were no in-kernel users.

> POV.  We use it in the coredump code and I don't think we'd be likely to want
> to rip it out.

OK, I understand that the unwritten policy is the following:
symbols for out-of-tree code used by OSDL are fine. 8)

> In fact, I'd say that complete() should have always done it this way...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/