To: Greg KH <greg@kroah.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, akpm@osdl.org,
       linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH][3/26] IB/mthca: improve CQ locking part 1
References: <2005331520.cHJfJcRbBu1fFgB6@topspin.com>
	<4227AD34.4050002@pobox.com> <20050304005824.GA18411@kroah.com>
	<527jkonryr.fsf@topspin.com> <20050304163357.GB28179@kroah.com>
From: Roland Dreier <roland@topspin.com>
Date: Fri, 04 Mar 2005 08:43:06 -0800
In-Reply-To: <20050304163357.GB28179@kroah.com> (Greg KH's message of "Fri,
 4 Mar 2005 08:33:58 -0800")
Message-ID: <521xavmkf9.fsf@topspin.com>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Jumbo Shrimp, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 743
Lines: 22

    Roland> What would pci_irq_sync() do exactly?

    Greg> Consolidate common code like this?  :)

I don't see how one can do that.  As I pointed out in my reply to
Jeff, it actually requires understanding how the driver uses the
different MSI-X vectors to know which vector we need to synchronize
against.  So it seems pci_irq_sync() would have to be psychic.

If we can figure out how to do that, maybe we can consolidate a lot
more code into an API like

	void do_what_i_mean(void);

;)

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/