Date: Sat, 5 Mar 2005 11:39:56 +0100
From: Willy Tarreau <willy@w.ods.org>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, akpm@osdl.org
Subject: Re: [patch] remove the `.' in EXTRAVERSION usage
Message-ID: <20050305103956.GH30106@alpha.home.local>
References: <2cd57c90050305022211b94e86@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2cd57c90050305022211b94e86@mail.gmail.com>
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1391
Lines: 37

On Sat, Mar 05, 2005 at 06:22:45PM +0800, Coywolf Qi Hunt wrote:
> Since 2.6.9, there came along the LOCALVERSION for people to add local
> version in make menuconfig which was EXTRAVERSION originally for imho.
> Now EXTRAVERSION goes just as a kernel version number, it's reasonable
> to remove the `.' in its usage.
> 
> Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
> 
> diff -Nrup 2.6.11/Makefile 2.6.11-cy/Makefile
> --- 2.6.11/Makefile	2005-03-03 17:10:57.000000000 +0800
> +++ 2.6.11-cy/Makefile	2005-03-05 16:40:46.000000000 +0800
> @@ -1,7 +1,7 @@
> VERSION = 2
> PATCHLEVEL = 6
> SUBLEVEL = 11
> -EXTRAVERSION =
> +EXTRAVERSION = 1
> NAME=Woozy Numbat
> 
> # *DOCUMENTATION*
> @@ -158,7 +158,7 @@ LOCALVERSION = $(subst $(space),, \
>  	       $(shell cat /dev/null $(localver)) \
>  	       $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
>  
> -KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)$(LOCALVERSION)
> +KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL).$(EXTRAVERSION)$(LOCALVERSION)

Please don't do that, you'll always end up with a trailing dot in 3-numbers
versions. Eg: V=2 P=6 S=11 => "2.6.11."

Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/