Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261261AbVCFA0m (ORCPT ); Sat, 5 Mar 2005 19:26:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261274AbVCFAYE (ORCPT ); Sat, 5 Mar 2005 19:24:04 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:24461 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261264AbVCEX6u (ORCPT ); Sat, 5 Mar 2005 18:58:50 -0500 Date: Sat, 5 Mar 2005 23:58:38 +0000 From: Christoph Hellwig To: Kai Germaschewski Cc: Adrian Bunk , Rusty Russell , Andrew Morton , Sam Ravnborg , Vincent Vanackere , keenanpepper@gmail.com, lkml - Kernel Mailing List Subject: Re: Undefined symbols in 2.6.11-rc5-mm1 Message-ID: <20050305235837.GB31261@infradead.org> Mail-Followup-To: Christoph Hellwig , Kai Germaschewski , Adrian Bunk , Rusty Russell , Andrew Morton , Sam Ravnborg , Vincent Vanackere , keenanpepper@gmail.com, lkml - Kernel Mailing List References: <20050305153638.GD6373@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 871 Lines: 17 On Sat, Mar 05, 2005 at 11:36:23AM -0500, Kai Germaschewski wrote: > However, I spoke too soon. There actually is a legitimate use for > EXPORT_SYMBOL() in a lib-y object, e.g. lib/dump_stack.c. This provides a > default implementation for dump_stack(). Most archs provide their own > implementation (and EXPORT_SYMBOL() it), and in this case we definitely > want the default version in lib to be thrown away, including its > EXPORT_SYMBOL. So the appended patch throws false positives and thus can > not be applied. .. and should be replaced by CONFIG_GENERIC_DUMP_STACK or __HAVE_ARCH_DUMP_STACK or something similar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/