Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261513AbVCFWQ3 (ORCPT ); Sun, 6 Mar 2005 17:16:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261515AbVCFWQ2 (ORCPT ); Sun, 6 Mar 2005 17:16:28 -0500 Received: from mailhub2.nextra.sk ([195.168.1.110]:42257 "EHLO toe.nextra.sk") by vger.kernel.org with ESMTP id S261513AbVCFWQT (ORCPT ); Sun, 6 Mar 2005 17:16:19 -0500 Message-ID: <422B8166.7060102@rainbow-software.org> Date: Sun, 06 Mar 2005 23:17:10 +0100 From: Ondrej Zary User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Domen Puncer CC: emoenke@gwdg.de, linux-kernel@vger.kernel.org, nacc@us.ibm.com Subject: Re: [patch 2/6] 12/34: cdrom/cdu31a: replace interruptible_sleep_on() with wait_event_interruptible() References: <20050306103155.4AC7D1F202@trashy.coderock.org> <422AECBF.7040507@rainbow-software.org> <20050306210426.GA32564@nd47.coderock.org> In-Reply-To: <20050306210426.GA32564@nd47.coderock.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 45 Domen Puncer wrote: > On 06/03/05 12:42 +0100, Ondrej Zary wrote: > >>domen@coderock.org wrote: >> >>>Use wait_event_interruptible() instead of the deprecated >>>interruptible_sleep_on(). The patch is straight-forward as the macros >>>should result in the same execution. Patch is compile-tested (still throws >>>out warnings >>>regarding {save,restore}_flags()). >>> >>>Signed-off-by: Nishanth Aravamudan >>>Signed-off-by: Domen Puncer >> > > Uh, this one escaped me, as schedule() (sleep_on) after cli() is clearly > wrong. Btw. what was the reason for this? I've never tried the IRQ-driven operation so I don't know if that code still works (it certainly used to for the original author some years ago). I think that it should wait until the IRQ from the drive arrives. >>I've posted a patch for the cdu31a driver some time ago that removes >>almost all usage of interruptible_sleep_on() and also >>{save,restore}_flags() - it uses semaphore instead. >>The only remaining code is in sony_sleep() function when using >>IRQ-driven operation. >> >>See http://lkml.org/lkml/2004/12/18/107 >>The patch is big because I've messed with the formatting... > > > I looked at it, and rewrote some of it into smaller patches. If you don't > mind, can i send them to you for review and testing? Thanks. I'll test them. I guess that these smaller patches are more likely to be accepted into mainline. -- Ondrej Zary - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/