Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261586AbVCFWpb (ORCPT ); Sun, 6 Mar 2005 17:45:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261587AbVCFWnp (ORCPT ); Sun, 6 Mar 2005 17:43:45 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:6565 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261586AbVCFWiR (ORCPT ); Sun, 6 Mar 2005 17:38:17 -0500 Date: Sun, 6 Mar 2005 22:38:15 +0000 From: Christoph Hellwig To: OGAWA Hirofumi Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 4/29] let fat handle MS_SYNCHRONOUS flag Message-ID: <20050306223815.GA5827@infradead.org> Mail-Followup-To: Christoph Hellwig , OGAWA Hirofumi , linux-kernel@vger.kernel.org, Andrew Morton References: <87ll92rl6a.fsf@devron.myhome.or.jp> <87hdjqrl44.fsf@devron.myhome.or.jp> <87d5uerl2j.fsf_-_@devron.myhome.or.jp> <878y52rl17.fsf_-_@devron.myhome.or.jp> <874qfqrl03.fsf_-_@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874qfqrl03.fsf_-_@devron.myhome.or.jp> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 19 > mark_buffer_dirty(bh); > + if (sb->s_flags & MS_SYNCHRONOUS) > + sync_dirty_buffer(bh); These three lines are duplicated a lot. I think you want a helper ala: static inline void fat_buffer_modified(struct super_block *sb, struct buffer_head *bh) { mark_buffer_dirty(bh); if (sb->s_flags & MS_SYNCHRONOUS) sync_dirty_buffer(bh); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/