Date: Sun, 6 Mar 2005 21:31:29 -0800
From: Andrew Morton <akpm@osdl.org>
To: Nish Aravamudan <nish.aravamudan@gmail.com>
Cc: domen@coderock.org, linux-kernel@vger.kernel.org, nacc@us.ibm.com,
       mochel@digitalimplant.org, greg@kroah.com
Subject: Re: [patch 12/14] drivers/dmapool: use TASK_UNINTERRUPTIBLE instead
 of TASK_INTERRUPTIBLE
Message-Id: <20050306213129.0d6a1504.akpm@osdl.org>
In-Reply-To: <29495f1d0503062101549b14e8@mail.gmail.com>
References: <20050306223654.3EE871EC90@trashy.coderock.org>
	<20050306194414.68239e90.akpm@osdl.org>
	<29495f1d0503062101549b14e8@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 855
Lines: 18

Nish Aravamudan <nish.aravamudan@gmail.com> wrote:
>
> > Also, __set_current_state() can be user here: the add_wait_queue() contains
>  > the necessary barriers.  (Grubby, but we do that in quite a few places with
>  > this particular code sequence (we should have an add_wait_queue() variant
>  > which does the add_wait_queue+__set_current_state all in one hit (but let's
>  > not, else I'll be buried in another 1000 cleanuplets))).
> 
>  Ok, I will re-spin this patch. Or would you prefer an incremental one?

Let's forget about this one while we work out whether that code is doing
what we want it to do.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/