Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261676AbVCGHXI (ORCPT ); Mon, 7 Mar 2005 02:23:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261661AbVCGHWw (ORCPT ); Mon, 7 Mar 2005 02:22:52 -0500 Received: from iabervon.org ([66.92.72.58]:25093 "EHLO iabervon.org") by vger.kernel.org with ESMTP id S261666AbVCGHNH (ORCPT ); Mon, 7 Mar 2005 02:13:07 -0500 Date: Mon, 7 Mar 2005 02:14:17 -0500 (EST) From: Daniel Barkalow To: Vojtech Pavlik cc: Benoit Boissinot , Dmitry Torokhov , Linux Kernel Mailing List , Andrew Morton Subject: Re: New ALPS code in -mm In-Reply-To: <20050304211327.GA5636@ucw.cz> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 28 On Fri, 4 Mar 2005, Vojtech Pavlik wrote: > /* Relative movement packet */ > if (z == 127) { > - input_report_rel(dev2, REL_X, (x > 383 ? x : (x - 768))); > - input_report_rel(dev2, REL_Y, -(y > 255 ? y : (x - 512))); > + input_report_rel(dev2, REL_X, (x > 383 ? (x - 768) : x)); > + input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y)); Not that I have any idea, but (y - 512) seems much more likely here. > + if ((priv->i->flags & ALPS_DUALPOINT) && z == 127) { > + input_report_key(dev2, BTN_LEFT, left); > + input_report_key(dev2, BTN_RIGHT, right); > + input_report_key(dev2, BTN_MIDDLE, middle); > + input_report_rel(dev2, REL_X, (x > 383 ? (x - 768) : x)); > + input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y)); Also here. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/