Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261717AbVCGJPH (ORCPT ); Mon, 7 Mar 2005 04:15:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261718AbVCGJPH (ORCPT ); Mon, 7 Mar 2005 04:15:07 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:8668 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261717AbVCGJPB (ORCPT ); Mon, 7 Mar 2005 04:15:01 -0500 Date: Mon, 7 Mar 2005 10:14:48 +0100 From: Pavel Machek To: "Barry K. Nathan" Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kconfig: DEBUG_PAGEALLOC and SOFTWARE_SUSPEND are incompatible on i386 Message-ID: <20050307091448.GC8311@elf.ucw.cz> References: <20050306030852.23eb59db.akpm@osdl.org> <20050306225730.GA1414@elf.ucw.cz> <20050306195954.6d13cff9.akpm@osdl.org> <20050307051241.GA5083@ip68-4-98-123.oc.oc.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050307051241.GA5083@ip68-4-98-123.oc.oc.cox.net> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 35 On Ne 06-03-05 21:12:41, Barry K. Nathan wrote: > On i386, SOFTWARE_SUSPEND requires the CPU to have PSE support, but > DEBUG_PAGEALLOC disables PSE. Thus, allowing both options to be enabled > simultaneously makes no sense. This patch disables DEBUG_PAGEALLOC if > SOFTWARE_SUSPEND is enabled; it also displays a comment to briefly > explain why DEBUG_PAGEALLOC is missing in that case. ACK. Pavel > --- linux-2.6.11-bk2/arch/i386/Kconfig.debug 2004-12-24 13:34:45.000000000 -0800 > +++ linux-2.6.11-bk2-bkn2/arch/i386/Kconfig.debug 2005-03-06 20:59:07.000000000 -0800 > @@ -38,9 +38,12 @@ > > This option will slow down process creation somewhat. > > +comment "Page alloc debug is incompatible with Software Suspend on i386" > + depends on DEBUG_KERNEL && SOFTWARE_SUSPEND > + > config DEBUG_PAGEALLOC > bool "Page alloc debugging" > - depends on DEBUG_KERNEL > + depends on DEBUG_KERNEL && !SOFTWARE_SUSPEND > help > Unmap pages from the kernel linear mapping after free_pages(). > This results in a large slowdown, but helps to find certain types -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/