Date: Tue, 8 Mar 2005 05:34:06 +0000
From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: alan@redhat.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       luc@saillard.org, torvalds@osdl.org
Subject: Re: [PATCH] Restore PWC driver
Message-ID: <20050308053405.GA1172@infradead.org>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	Greg KH <greg@kroah.com>, alan@redhat.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	luc@saillard.org, torvalds@osdl.org
References: <200503072216.j27MGLqR024373@hera.kernel.org> <20050308052643.GA16222@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050308052643.GA16222@kroah.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1028
Lines: 21

On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote:
> Ick, Alan, couldn't you have had the decency to run this through the USB
> developers, and at least pinged me on it?  Especially due to all of the
> hate-email I have gotten over this driver in the past.
> 
> As it is, the coding style sucks in places, and you didn't really need
> to make it a new subdirectory (although due to the increased size of the
> driver, it's probably better now...)
> 
> And, there's no MAINTAINERS entry for who I need to bug about this
> thing.

Agree with greg on all these bits, and similar (although not as bad) for
the other bits Alan sent.  Alan, could you please go through the subsystem
maintainer & -mm process like everyone else?  A little public review
can't hurt your patches either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/