Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261583AbVCHXRB (ORCPT ); Tue, 8 Mar 2005 18:17:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262174AbVCHXQ1 (ORCPT ); Tue, 8 Mar 2005 18:16:27 -0500 Received: from mail0.lsil.com ([147.145.40.20]:44999 "EHLO mail0.lsil.com") by vger.kernel.org with ESMTP id S262181AbVCHXJn (ORCPT ); Tue, 8 Mar 2005 18:09:43 -0500 Message-ID: <0E3FA95632D6D047BA649F95DAB60E570230CC18@exa-atlanta> From: "Bagalkote, Sreenivas" To: "'Arjan van de Ven'" Cc: "'linux-kernel@vger.kernel.org'" , "'linux-scsi@vger.kernel.org'" , "'James Bottomley'" , "'Matt_Domsch@Dell.com'" , Andrew Morton , "'Christoph Hellwig'" Subject: RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers Date: Tue, 8 Mar 2005 18:08:36 -0500 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2657.72) Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 23 > >> +static int is_dma64; > >the fact that this is a global variable worries me. > Matt also has the same concern. I am pasting my response from my reply to his comment: I will make this an instance parameter if the idea to reduce as many global variables as possible. But if the objection is because each adapter may have different value for variable, then it is indeed a global value. "is_dma64" - which is computed using the size of dma_addr_t - is telling something about the kernel rather than the controller feature. Thanks, Sreenivas LSI Logic Corporation - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/